refactor: add conftest command into testing-image for refactoring e2e conftest ensure logic to upgrade conftest upgrading #2811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
conftest
command in testing-image, notconftest$version
commandwhy
Based on #2807 (comment) discussion, we want to remove e2e ocontroller version specific conftest command like
atlantis/server/controllers/events/events_controller_e2e_test.go
Lines 1366 to 1372 in 6a7f79e
This version specific dependency is hard to upgrade conftest automatically.
To remove version dependency, I just add
conftest
comand. I will change e2e by using this command in the next PR.references