Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention --enable-regexp-cmd requires the project name key #2796

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Dec 14, 2022

what

  • Mention --enable-regexp-cmd requires the project name key

why

  • Without the optional name key defined, the --enable-regexp-cmd with atlantis plan -p .* will return nothing.

references

if p.EnableRegExpCmd {
projectsCfg = repoCfg.FindProjectsByName(projectName)
} else {
if p := repoCfg.FindProjectByName(projectName); p != nil {
projectsCfg = append(projectsCfg, *p)
}
}

for _, p := range r.Projects {
if p.Name != nil {
if match, _ := regexp.MatchString(sanitizedName, *p.Name); match {
ps = append(ps, p)
}
}
}

@nitrocode nitrocode added the docs Documentation label Dec 14, 2022
@nitrocode nitrocode requested a review from a team as a code owner December 14, 2022 16:26
Copy link
Member

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamengual jamengual merged commit 585ce1e into main Dec 15, 2022
@jamengual jamengual deleted the docs-enable-regexp branch December 15, 2022 21:51
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…unatlantis#2796)

* docs: mention the name key for regexp cmd

* docs: add name key to auto-generation
@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants