-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Metrics initialization #2767
bugfix: Metrics initialization #2767
Conversation
Please tell me if adding the |
hard to know about the name since in the same file there is some sort of a pattern but then the is another function that does not follow the same name pattern.... @nitrocode @lilincmu what do you guys think? |
Made some changes to make this code look a little more like I was forced to implement the function Lines 682 to 690 in 4d95783
It's not clear to me why this is necessary. |
61d5c5a
to
3db6f7e
Compare
3db6f7e
to
66dc30e
Compare
Made some mess with git here, sorry. Anyway, added the same logic for the other instrumented which I believe would be the places where this initialization would be applicable. |
5d7af42
to
8732f46
Compare
cc @albertorm95 for an extra set of eyes |
A function inside of the metrics package also makes sense to me. Thank you for taking the time to do this @Fabianoshz |
Looks good to me.
|
I will add the function and move this out of draft later today. |
what
why
references