fix(gitlab_client): prevent duplicate pipelines in gitlab merge requests #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
reviewed
Dec 2, 2022
nitrocode
reviewed
Dec 5, 2022
|
@michelmzs were you able to build this and test this out in your setup? |
nitrocode
approved these changes
Dec 7, 2022
Yes, please take a look @nitrocode:
|
|
Great thank you @michelmzs ! cc: @jamengual please review one last time |
jamengual
approved these changes
Dec 7, 2022
|
Thanks you @michelmzs |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…sts (runatlantis#2745) * fix(gitlab_client): change CommitStatus update logic to prevent duplicated pipelines in MRs * chore: refactor refTarget logic * chore: fix tests * chore: fix lint * chore: remove nested if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add instructions to
SetCommitStatusto avoid duplicate pipelines in GitLab Merge Requests.Why
GitLab pipeline can have multiple sources, the common usage for Atlantis are:
merge_request_eventsourceWhen a
gitlab-ci.yamlrule enforces its creationexternalsourceWhen no job is defined in gitlab-ci.yaml.
References
closes #2743