Use single github v4 client #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysoldak
force-pushed
the
single-ghv4-client
branch
from
a79560d to
1411091
Compare
jamengual
added
waiting-on-review
|
1 week on prod, all systems nominal. |
|
Is there something pending to push this one through, or only reviews? |
From my point of view this PR is second in PR train, builds upon a change in another PR. |
|
@ysoldak is it ready or is it still a Draft? |
ysoldak
force-pushed
the
single-ghv4-client
branch
from
1411091 to
7731772
Compare
|
Sorry for so many go.mod changes, this is result of |
@jamengual ready now |
lilincmu
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is second phase of GitHub v4 client refactoring.
First phase, see #2479 (I shall rebase once that PR is merged)
It seem we don't need two v4 clients anymore, since Minimize Comment schema is official now.
This PR removes unnecessary code and dependency.
Diff w/o #2479 commits: https://github.com/ysoldak/atlantis/compare/ghv4-plus-ghapp...ysoldak:atlantis:single-ghv4-client?expand=1