-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set mergeable correctly when branch protection doesn't require reviewers #2470
Merged
lilincmu
merged 4 commits into
runatlantis:master
from
stasostrovskyi:mergeable_no_reviewers
Sep 8, 2022
Merged
fix: Set mergeable correctly when branch protection doesn't require reviewers #2470
lilincmu
merged 4 commits into
runatlantis:master
from
stasostrovskyi:mergeable_no_reviewers
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's my first contribution to Atlantis and also my first time writing on go, so please let me know everything I need to know about code style :) |
1 week on prod, all systems nominal. |
lilincmu
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for your contribution 🎉
lilincmu
reviewed
Sep 8, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…eviewers (runatlantis#2470) * Allow no required reviewers * Fix comment in tests Co-authored-by: Stas Ostrovskyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2469. Verified both with unit test and real-life GitHub API