Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set mergeable correctly when branch protection doesn't require reviewers #2470

Merged
merged 4 commits into from
Sep 8, 2022
Merged

fix: Set mergeable correctly when branch protection doesn't require reviewers #2470

merged 4 commits into from
Sep 8, 2022

Conversation

stasostrovskyi
Copy link
Contributor

@stasostrovskyi stasostrovskyi commented Aug 25, 2022

Resolves #2469. Verified both with unit test and real-life GitHub API

@stasostrovskyi stasostrovskyi requested a review from a team as a code owner August 25, 2022 13:31
@stasostrovskyi
Copy link
Contributor Author

It's my first contribution to Atlantis and also my first time writing on go, so please let me know everything I need to know about code style :)

@ysoldak
Copy link
Contributor

ysoldak commented Sep 7, 2022

1 week on prod, all systems nominal.

Copy link
Contributor

@lilincmu lilincmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution 🎉

server/events/vcs/github_client_test.go Show resolved Hide resolved
@lilincmu lilincmu merged commit b8297bb into runatlantis:master Sep 8, 2022
@nitrocode nitrocode removed the waiting-on-review Waiting for a review from a maintainer label Nov 11, 2022
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…eviewers (runatlantis#2470)

* Allow no required reviewers

* Fix comment in tests

Co-authored-by: Stas Ostrovskyi <[email protected]>
@nitrocode nitrocode added this to the v0.19.9 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mergeable status is always false when branch GH protection doesn't require reviewers
5 participants