feat: add a flag to silence policy checks comments when there's no error #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
added
waiting-on-review
|
@Fauzyy can you add Tests? |
|
@jamengual yes will do! |
Fauzyy
force-pushed
the
Fauzyy/quiet-policy-checks
branch
from
092fd5f to
a9d9efb
Compare
|
Hi @jamengual, I added a couple test cases to the events controller e2e - thank you |
Fauzyy
changed the title
|
Hey @jamengual, I just wanted to see what else is required to get this merged. Thanks! |
|
time, time , time
…On Fri, Sep 2, 2022 at 11:24 AM Marc Barlo ***@***.***> wrote:
Hey @jamengual <https://github.com/jamengual>, I just wanted to see what
else is required to get this merged. Thanks!
—
Reply to this email directly, view it on GitHub
<#2405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3ERC7RE56SSROCN43MY3V4JA5JANCNFSM54A25XQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jamengual
approved these changes
Sep 21, 2022
|
@Fauzyy could you please the conflicts? |
|
@jamengual done! Sorry about the slow response here, I was away |
nitrocode
approved these changes
Oct 20, 2022
jamengual
approved these changes
Oct 20, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…ror (runatlantis#2405) * Add a flag to silence policy checks comments when there's no error * Add e2e test cases for the quiet policy checks flag * add documentation for quiet-policy-checks flag * Update user_config.go Fix indentation * Update user_config.go * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new server config flag
quiet-policy-checkswhich exclude policy check comments from pull requests unless there's an actual error from conftest.This helps cut down some noise on PRs, especially when planning multiple workspaces at once where you have multiple conftest comments.
Testing
We've been using this in our fork for several months. I've also added a few test cases to the events controller e2e.