Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[fix] Ignore commit checks for atlantis apply on Github (#2311)" #2388

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

lilincmu
Copy link
Contributor

Description

This PR reverts a change that accidentally introduced regression described by #2112, where an unmergeable GitHub PR can be applied when apply_requirements: [mergeable] is set.

Disclaimer: This PR doesn't implement additional features that cover more use cases, but only tries to resolve the regression.

Notes

This reverts commit a3db712.
Revert "[fix] Ignore commit checks for atlantis apply on Github (#2311)"

@lilincmu lilincmu requested a review from a team as a code owner July 13, 2022 22:47
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LI, thanks

@lilincmu lilincmu merged commit e153cea into runatlantis:master Jul 14, 2022
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…tlantis#2311)" (runatlantis#2388)

* Revert "[fix] Ignore commit checks for atlantis apply on Github (runatlantis#2311)"

This reverts commit a3db712.
@nitrocode nitrocode modified the milestones: v0.19.8, v0.19.7 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants