Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update streaming-logs #2313

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

alex-bezek
Copy link
Contributor

Hello, I was reading through these docs and this section seemed incorrect. I assume the 2 commands it supports are atlantis plan/apply and not the underlying 3 terraform commands. Let me know if I'm misinterpreting this. Thanks!

Hello, I was reading through these docs and this section seemed incorrect. I assume the 2 commands it supports are atlantis plan/apply and not the underlying 3 terraform commands. Let me know if I'm misinterpreting this. Thanks!
@alex-bezek alex-bezek requested a review from a team as a code owner June 13, 2022 15:23
@jamengual
Copy link
Contributor

@alex-bezek did you pull from master recently? the tests should not be failing so if you can pull to make sure you are in the latest changes it should fix it

@alex-bezek
Copy link
Contributor Author

@jamengual I just made the change through the UI so it should be up to date. It looks like the master branch is failing https://app.circleci.com/pipelines/github/runatlantis/atlantis?branch=master

The tests seem to be failing on this ioutil line and this err

@alex-bezek
Copy link
Contributor Author

alex-bezek commented Jun 13, 2022

I tried to fix the test here but it has other errors now which I'm not sure about

@chenrui333 chenrui333 changed the title Update streaming-logs.md docs docs: update streaming-logs Jun 13, 2022
@alex-bezek
Copy link
Contributor Author

Tests pass now, thanks @chenrui333 !

@jamengual jamengual merged commit a3b9f7c into runatlantis:master Jun 13, 2022
@alex-bezek alex-bezek deleted the patch-1 branch June 14, 2022 05:43
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
Hello, I was reading through these docs and this section seemed incorrect. I assume the 2 commands it supports are atlantis plan/apply and not the underlying 3 terraform commands. Let me know if I'm misinterpreting this. Thanks!

Co-authored-by: Rui Chen <[email protected]>
@nitrocode nitrocode added this to the v0.19.5 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants