Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unmarshall error in graphql call #2128

Merged
merged 3 commits into from
Mar 9, 2022
Merged

fix: fix unmarshall error in graphql call #2128

merged 3 commits into from
Mar 9, 2022

Conversation

raymondchen625
Copy link
Contributor

This should fix issue #2090 by using the right client from shurcooL's library.
Notes: By using GraphQL new scopes ['read:org', 'read:discussion'] are required by the OAuth token. C.f. https://docs.github.com/en/graphql/guides/forming-calls-with-graphql

@raymondchen625 raymondchen625 requested a review from a team as a code owner March 8, 2022 13:19
@raymondchen625 raymondchen625 changed the title Fix unmarshall error in GraphQL call #2090 Fix unmarshall error in GraphQL call Mar 8, 2022
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you also add some tests for the change?

@chenrui333 chenrui333 changed the title Fix unmarshall error in GraphQL call fix: fix unmarshall error in graphql call Mar 8, 2022
@jamengual
Copy link
Contributor

@raymondchen625 could you check the lint errors? Thanks

@jamengual jamengual merged commit 4e45685 into runatlantis:master Mar 9, 2022
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
* Fix unmarshall error in GraphQL call runatlantis#2090

* Add unit tests for GetTeamNamesForUser

* Fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants