fix(bitbucketcloud): Ensure status key has at most 40 characters #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
fix/bitbucketcloud/update-status-key-too-long
branch
from
6132539 to
c024330
Compare
maxbrunet
force-pushed
the
fix/bitbucketcloud/update-status-key-too-long
branch
from
c024330 to
0d0458f
Compare
chenrui333
approved these changes
Mar 7, 2022
|
Thanks @maxbrunet!! |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…atlantis#2037) * fix(bitbucketcloud): Ensure status key has at most 40 characters * Use fmt.Sprintf()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed this error:
{ "level": "error", "ts": "2022-02-01T20:21:06.571Z", "caller": "events/project_command_runner.go:156", "msg": "updating project PR status%!(EXTRA *errors.errorString=making request \"POST https://api.bitbucket.org/2.0/repositories/myworkspace/myrepo/commit/abc1605a840c/statuses/build\" unexpected status code: 400, body: {\"type\": \"error\", \"error\": {\"fields\": {\"key\": [\"Ensure this value has at most 40 characters (it has 53).\"]}, \"message\": \"key: Ensure this value has at most 40 characters (it has 53).\"}})", "json": { "repo": "myworkspace/myrepo", "pull": "19" }, "stacktrace": "github.com/runatlantis/atlantis/server/events.(*ProjectOutputWrapper).updateProjectPRStatus\n\tgithub.com/runatlantis/atlantis/server/events/project_command_runner.go:156\ngithub.com/runatlantis/atlantis/server/events.(*ProjectOutputWrapper).Apply\n\tgithub.com/runatlantis/atlantis/server/events/project_command_runner.go:133\ngithub.com/runatlantis/atlantis/server/events.runProjectCmds\n\tgithub.com/runatlantis/atlantis/server/events/project_command_pool_executor.go:47\ngithub.com/runatlantis/atlantis/server/events.(*ApplyCommandRunner).Run\n\tgithub.com/runatlantis/atlantis/server/events/apply_command_runner.go:146\ngithub.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand\n\tgithub.com/runatlantis/atlantis/server/events/command_runner.go:252" }It may not be the fanciest way to truncate a string and add an ellipsis (e.g. slicingbytes vsrunes issue...), but it should be enough for most cases here (if not we can always improve later imo)