docs: document approve_policies command in comment_parser #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupuy26
commented
Nov 8, 2021
|
if it's not too much of a stretch you might want to add the word to the footer of the comment when there are failures. Saves reviewers time looking it up |
|
Thanks for doing this! Looks like there's some tests failing though! If you could fix those we can get this in. |
dupuy26
changed the title
The `approve_policies` command was added with policy checking but was never included in the command parser help. Also update the comments in the file to reflect all of the commands.
Excellent idea – I have updated that text to include the specific command. |
dupuy26
force-pushed
the
patch-2
branch
3 times, most recently
from
cbe44ce to
c54e1f7
Compare
Include the specific command `approve_policies` in the message.
Now passing all tests for both modified help message and policy check failure error. |
jamengual
approved these changes
Nov 15, 2021
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…s#1886) * docs: document approve_policies command in help The `approve_policies` command was added with policy checking but was never included in the command parser help. Also update the comments in the file to reflect all of the commands. * feat: Better message on policy failure Include the specific command `approve_policies` in the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
approve_policiescommand was added with policy checking but wasnever included in the command parser help.
Add an explicit mention of the
approve_policiescommand in the errormessage on policy checking failure.
Also update the comments in the file to reflect all of the commands.