Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't comment back on autoplan no projects. #184

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jul 16, 2018

Fixes #183

@codecov
Copy link

codecov bot commented Jul 16, 2018

Codecov Report

Merging #184 into master will decrease coverage by 0.16%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage    74.3%   74.14%   -0.17%     
==========================================
  Files          53       53              
  Lines        2565     2568       +3     
==========================================
- Hits         1906     1904       -2     
- Misses        556      560       +4     
- Partials      103      104       +1
Impacted Files Coverage Δ
server/events/markdown_renderer.go 95.83% <100%> (-0.17%) ⬇️
server/events/command_runner.go 74.8% <16.66%> (-2.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7163ed5...84078dc. Read the comment docs.

@lkysow lkysow merged commit 0d1c08a into master Jul 16, 2018
@lkysow lkysow deleted the autoplan-notifications branch July 16, 2018 16:51
jamengual pushed a commit that referenced this pull request Nov 23, 2022
* Add platform mode flag to GlobalCfg

* Added server side config support for platform mode

* Adding flag to enable platform mode

* fix tests

* Moved some of the project level validations to project struct

Added platform mode config support for project level workflow overrides.
We do not support custom platform mode workflows on repo configs

* fix broken test

* moved validations to repo_cfg

* moved some repetitive code to helper functino

* remove platform mode changes

* clean up for loop

* remove platform mode values from project

* adding platform mode support to repo config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant