feat: add BasicAuth Support to Atlantis ServeHTTP #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @nishkrishnan can u please give a hand and review this PR please ? |
|
@chenrui333 there is any missing thing for this PR to go in ? |
chenrui333
changed the title
|
If putting Atlantis somewhere that requires healthchecks for availability, this now makes the |
|
I made a PR to address the issues this causes for using |
|
@fblgit the section https://www.runatlantis.io/docs/server-configuration.html was not updated with the new flags, could you please create another pr to add the new flags in that doc? thanks. |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* Add BasicAuth Support to Atlantis ServeHTTP * Added Security notes Co-authored-by: xmurias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Introduces the following flags:
--web-basic-auth=bool(false by default) to enable/disable basic-auth on the webserver--web-username=string(atlantis by default) to set the webserver username--web-password=string(atlantis by default) to set the webserver passwordBasicAuth feature over middleware HTTP server of Atlantis
/eventsis filtered out of the basic-auth requirement, as this element can be protected already by webhook secrets.Probably
RequestLoggershould be relabeled to something else that now identifies both the authentication, serving, and logging scenario for HTTP requests.Motivation:
Despite being able to apply different mechanisms with a layer in front of Atlantis, like ingress, I believe that is reasonable the capacity of scope the access to the HTTP server directly within Atlantis.