-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream Terraform output through web interface (take 2) #1759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @schultzor we're already working on a version from this inspired from the original PR with a couple modifications. We'll be testing this in production as well to make sure that it can handle a reasonable scale before patching it upstream. |
We did a patch for this time back, and u must consider these:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the existing work from this PR #1315 and updated it against the current main branch. I also added plumbing for a
ParallelCommand
type through the various interfaces for keeping track of commands that are invoked in parallel vs those invoked serially (currently this is only used for adding a command prefix on the webconsole output).I went ahead and opened a new PR for this since the previous one was marked as unmaintained, apologies if that was the wrong approach here 🙇