Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil pointer dereference when userConfig.DisableRepoLocking is true #1557

Merged
merged 2 commits into from
May 10, 2021
Merged

Nil pointer dereference when userConfig.DisableRepoLocking is true #1557

merged 2 commits into from
May 10, 2021

Conversation

Fauzyy
Copy link
Contributor

@Fauzyy Fauzyy commented May 5, 2021

Description

This PR fixes the nil pointer dereference from #1551

When DisableRepoLocking is true, we should still initialize the new applyLockingClient

Testing

You can reproduce this by hitting the server index page
go run . server --disable-repo-locking=true --repo-allowlist=*

@Fauzyy Fauzyy requested a review from a team as a code owner May 5, 2021 17:06
acastle
acastle approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@acastle acastle merged commit ce57344 into runatlantis:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acastle acastle acastle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fauzyy @acastle