Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plan summary to unfolded part of comment #1518

Merged
merged 4 commits into from
Apr 22, 2021

Conversation

wkrysmann
Copy link
Contributor

If there are multiple projects planned and markdown folding is enabled user must click on each "Show details" button separately and scroll through the plan to check if there are any changes to the infrastructure. This may be pretty time consuming when multiple projects are planned. Some of them may not have any changes in them, due to the dependency resolution.
This PR adds the extra summary line, so user can quickly eyeball what is the impact of his change for each project without unfolding the output.
image

@wkrysmann wkrysmann requested a review from a team as a code owner April 20, 2021 03:41
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1518 (67cc3b7) into master (25103d7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
+ Coverage   70.21%   70.23%   +0.02%     
==========================================
  Files          94       94              
  Lines        6530     6535       +5     
==========================================
+ Hits         4585     4590       +5     
  Misses       1555     1555              
  Partials      390      390              
Impacted Files Coverage Δ
server/events/markdown_renderer.go 90.10% <100.00%> (ø)
server/events/models/models.go 75.00% <100.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25103d7...67cc3b7. Read the comment docs.

Copy link
Contributor

@nishkrishnan nishkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 👍

@nishkrishnan nishkrishnan merged commit 0886b28 into runatlantis:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants