Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(output): Remove Refreshing state... from output step 2 #1432

Closed

Conversation

mathcantin
Copy link
Contributor

Fix UTs on #1352

Since Terraform 0.14.0 there are no separator between refreshing plan and the plan.
@nishkrishnan
Copy link
Contributor

hmm, the branch tests didn't trigger? that's weird...

@mathcantin
Copy link
Contributor Author

hmm, the branch tests didn't trigger? that's weird...

I don't know. I run :

docker run --rm -v $(pwd):/go/src/github.com/runatlantis/atlantis -w /go/src/github.com/runatlantis/atlantis runatlantis/testing-env make test
and
docker run --rm -v $(pwd):/go/src/github.com/runatlantis/atlantis -w /go/src/github.com/runatlantis/atlantis runatlantis/testing-env make check-lint

on my computer. There are any others checks?

@nishkrishnan
Copy link
Contributor

Can you re-create the PR? There was a 400 when sending the webhook to circleci so it didn't show up here. We want to make sure tests pass completely in the PR before merging

@mathcantin
Copy link
Contributor Author

@nishkrishnan It's done #1433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants