Allow applying 0 projects when disable-apply-all is used #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new flag
--empty/-e
to theapply
command. This makes it possible to "apply" all changes when the--disable-apply-all
flag is set. Without this this you can't get such PR merged if Github hasatlantis/apply
as a required status check.TODO
Alternative solution
Instead of adding the
-e
flag to the apply command the check in command_runner.go#L217 can be postponed and allowatlantis apply
without flags if and only if there is zero projects to apply even if the--disable-apply-all
flag was used.Fixes: #1359