Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that refreshed creds are used to update remote. #1238

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

nishkrishnan
Copy link
Contributor

Fixes: #1236

Basically just ensures we are always using the latest credential URL in the case that we already have our repo cloned at the right commit and we want to check if master has diverged.

Additionally, also ensures we can still write creds even when our creds are nuked.

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #1238 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
+ Coverage   69.93%   70.00%   +0.06%     
==========================================
  Files          71       71              
  Lines        5359     5368       +9     
==========================================
+ Hits         3748     3758      +10     
+ Misses       1263     1262       -1     
  Partials      348      348              
Impacted Files Coverage Δ
server/events/git_cred_writer.go 78.94% <100.00%> (+1.16%) ⬆️
server/events/working_dir.go 77.77% <100.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab63bc...1110c52. Read the comment docs.

@nishkrishnan nishkrishnan merged commit 1513089 into runatlantis:master Dec 2, 2020
@nishkrishnan nishkrishnan deleted the fix-for-1236 branch March 2, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expired Git App credentials fail Remote Updating during divergence check
1 participant