Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1193] Fix merge strategy for gh apps #1225

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Conversation

nishkrishnan
Copy link
Contributor

Fixes #1193 by introducing a small refactor to not pass duplicate Repo objects by referencing the base repository through the PullRequest object only.

This also fixes the clone url sanitizing for gh apps which wasn't accurate.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1225 into master will increase coverage by 0.00%.
The diff coverage is 77.27%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1225   +/-   ##
=======================================
  Coverage   69.93%   69.93%           
=======================================
  Files          71       71           
  Lines        5358     5359    +1     
=======================================
+ Hits         3747     3748    +1     
  Misses       1263     1263           
  Partials      348      348           
Impacted Files Coverage Δ
server/events/vcs/github_credentials.go 73.33% <ø> (ø)
server/events/command_runner.go 50.71% <23.07%> (-0.35%) ⬇️
server/events/github_app_working_dir.go 62.50% <100.00%> (+8.65%) ⬆️
server/events/project_command_builder.go 78.92% <100.00%> (ø)
server/events/project_command_runner.go 73.33% <100.00%> (ø)
server/events/working_dir.go 75.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82e9f0...0a7d644. Read the comment docs.

@lkysow
Copy link
Member

lkysow commented Oct 23, 2020

Thanks Nish for contributing this back! Lyft's fork looks like ya'll have some cool features over there!

@lkysow lkysow merged commit 276b4ad into runatlantis:master Oct 23, 2020
@nishkrishnan nishkrishnan deleted the issue-1193 branch March 2, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge strategy does not work
2 participants