Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock cmd #1090

Merged
merged 24 commits into from
Jun 24, 2020
Merged

Unlock cmd #1090

merged 24 commits into from
Jun 24, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jun 24, 2020

Refactors #1003

Paris Morali and others added 24 commits June 8, 2020 15:56
This successfully deletes the atlantis lock and
allows a competing PR to plan, but doesn not delete
the actual plans, so a user can still apply after
the lock is discarded.
This will be investigated in a follow up commit

Also fixed the basic mark down rendering for the discard command
Specifically deleting plans via VCS commenting now reuses
the same logic as the LockController which is used by the
UI delete plan action.
Also via VCS commenting it's only possible atm to delete all
the plans involved in the PR, as well as release all related
Atlantis locks
Just trying to keep this as simple as possible
Also supply usage tip when unlock is used incorrectly
@lkysow lkysow merged commit 8ea72d4 into master Jun 24, 2020
@lkysow lkysow deleted the unlock-cmd branch June 24, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant