-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock cmd #1090
Merged
Merged
Unlock cmd #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This successfully deletes the atlantis lock and allows a competing PR to plan, but doesn not delete the actual plans, so a user can still apply after the lock is discarded. This will be investigated in a follow up commit Also fixed the basic mark down rendering for the discard command
Specifically deleting plans via VCS commenting now reuses the same logic as the LockController which is used by the UI delete plan action. Also via VCS commenting it's only possible atm to delete all the plans involved in the PR, as well as release all related Atlantis locks
Co-authored-by: Luke Kysow <[email protected]>
Co-authored-by: Luke Kysow <[email protected]>
Just trying to keep this as simple as possible
Also supply usage tip when unlock is used incorrectly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors #1003