Ignore .tflint.hcl #1075
Merged
Ignore .tflint.hcl #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1061
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 67 67
Lines 5564 5564
=======================================
Hits 3978 3978
Misses 1272 1272
Partials 314 314
Continue to review full report at Codecov.
|
lkysow
requested changes
Jul 7, 2020
server/events/project_finder.go
Outdated
| @@ -40,6 +40,9 @@ type ProjectFinder interface { | |||
| DetermineProjectsViaConfig(log *logging.SimpleLogger, modifiedFiles []string, config valid.RepoCfg, absRepoDir string) ([]valid.Project, error) | |||
| } | |||
|
|
|||
| // IgnoredFiles contains filename fragments to ignore while looking at changes | |||
| var IgnoredFiles = [...]string{"terraform.tfstate", "terraform.tfstate.backup", "tflint.hcl"} | |||
There was a problem hiding this comment.
Suggested change
| var IgnoredFiles = [...]string{"terraform.tfstate", "terraform.tfstate.backup", "tflint.hcl"} | |
| var ignoredFilenameFragments = []string{"terraform.tfstate", "terraform.tfstate.backup", "tflint.hcl"} |
lowercase so it isn't exported and while I just learned about [...] (cool!) I think its best to keep things consistent.
server/events/project_finder.go
Outdated
| @@ -136,16 +139,16 @@ func (p *DefaultProjectFinder) filterToTerraform(files []string) []string { | |||
| for _, fileName := range files { | |||
| // Filter out tfstate files since they usually checked in by accident | |||
server/events/project_finder.go
Outdated
| // isStatefile returns true if fileName is a terraform statefile or backup. | ||
| func (p *DefaultProjectFinder) isStatefile(fileName string) bool { | ||
| for _, s := range []string{"terraform.tfstate", "terraform.tfstate.backup"} { | ||
| // shouldIgnore returns true if fileName is a terraform statefile, backup or tflint file. |
There was a problem hiding this comment.
Suggested change
| // shouldIgnore returns true if fileName is a terraform statefile, backup or tflint file. | |
| // shouldIgnore returns true if we shouldn't trigger a plan on changes to this file. |
|
You need to make the renaming changes to the use of the variable as well. |
|
Thanks! |
|
This PR is significantly smaller than your last one 😆 |
|
I'll do my best once I find some time to tackle #936 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1061