Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: apply on merge #36

Closed
atlantisbot opened this issue Mar 6, 2018 · 3 comments
Closed

feature request: apply on merge #36

atlantisbot opened this issue Mar 6, 2018 · 3 comments
Milestone

Comments

@atlantisbot
Copy link

Issue by @robertlabrie
Thursday Oct 19, 2017 at 12:21 GMT
Migrated from hootsuite/atlantis#162
Why was it migrated?


Would be great if merging a PR triggered a terraform apply

@atlantisbot
Copy link
Author

Comment by @robertlabrie
Monday Oct 23, 2017 at 11:41 GMT


piling on my own request, plan on push would be dandy as well :)

@atlantisbot
Copy link
Author

Comment by @lkysow
Monday Oct 23, 2017 at 13:42 GMT


Thanks for the ticket! The main reason we do apply on comment is that often there are errors when you run apply. If this happens then it's easier to push a change to an open pull request and run plan/apply again.

That being said, I don't think there's a reason we couldn't also support a final apply on merge for any plans that are outstanding. What do you think @anubhavmishra?

For plan on push, we definitely agree this is needed. I created #165 to track this separately.

@lkysow lkysow added this to the 0.4 milestone Mar 15, 2018
@lkysow
Copy link
Member

lkysow commented Jul 4, 2018

I've decided against doing this for now. Although there are valid use-cases for applying after merge, I'd like to focus on the most common use-cases where applying on the pull request and locking the directory until the pull request is merged works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants