Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of PR check status of Plan Succeeded show Plan: 1 to add, 0 to change, 1 to destroy #2625

Closed
1 task done
nitrocode opened this issue Oct 27, 2022 · 6 comments · Fixed by #2983
Closed
1 task done
Labels
feature New functionality/enhancement

Comments

@nitrocode
Copy link
Member

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

I'd like to see terraform plan summaries as PR status messages instead of just "Plan Succeeded"

Describe the solution you'd like

Use the terraform plan JSON to retrieve the summary of the plan use that as the successful PR terraform plan's check's message. This is how it's done in spacelift.

Plan contains no changes.

This is an image

Plan: 1 to add, 0 to change, 1 to destroy

This is an image

Describe the drawbacks of your solution

N/A

Describe alternatives you've considered

N/A

@nitrocode nitrocode added the feature New functionality/enhancement label Oct 27, 2022
@jamengual
Copy link
Contributor

If I can do a +1000 I will.

Eliminating repeated commenting and enhancing the status view makes for a very good user experience

@albertorm95
Copy link
Contributor

Is it hard to achieve?

@nitrocode
Copy link
Member Author

Nah, I'm sure it's doable. We just don't have a lot of time. If you'd like to propose a PR, I'd be honored to merge it in.

@jamengual
Copy link
Contributor

Same here

@jamengual
Copy link
Contributor

we will put a picture of you on the main page if you do it @albertorm95

@nitrocode
Copy link
Member Author

Seems to be a duplicate of #1267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
3 participants