feature request: warning for iam_policy_attachment

[maartenvanderhoef]

Hi! In an environment where any developer can create tf code. Would it be an idea to create warnings which stand out for [https://www.terraform.io/docs/providers/aws/r/iam_policy_attachment.html] iam_policy_attachment ? When applied wrongfully it can be quite disruptive, and it's easy to overlook when reviewing.

[lkysow]

Hi @maartenvanderhoef thanks for the ticket. I agree that it would be nice to have some sort of automated code review process built in to Atlantis but I'm not sure the best way to approach it. While I do see Atlantis being able to help with this at some point, it seems far off because I'm focused on getting the main workflow piece working smoothly for everyone.

I think for now, I'd recommend using the atlantis.yaml file to run your own hooks that do the review you want or using a secondary build process. What do you think?

[maartenvanderhoef]

That's fine.. enough on your list. For now I've fixed with it an extra run step after the plan. It will probably get annoying after a while..

• run: find . -name \"*.tf\" -exec grep -Hn aws_iam_policy_attachment {} \\; -print