Malformed Link to discard plan in PR/MR comment

[mechastorm]

Problem

When Atlantis generates a plan and display it as a comment, it usually says "To discard this plan click here."

The link to discard the plan seems to be malformed.

Example:

# On Github: 
https://github.com/myorg/myrepo/pull/myatlantis.domain.com/lock?id=myorg%252Fmyrepo%252Fterraform%252Fmydir%252Fmysubdir%252Fdefault

# On Gitlab
https://myprivategitlab.com/mygroup/myrepo/master/myatlantis.domain.com/lock?id=mygroup%252Fmyrepo%252Fmydir%252Fdefault

Repro Steps

1. Run atlantis plan
2. Click on the link to discard the plan

Expected Behavior

Should properly link to the Atlantis Web UI to discard the plan

Atlantis Version

atlantis 0.3.9

[lkysow]

What is your --atlantis-url flag set to? I think this is because it doesn't have a scheme http:// or https:// attached to it. Then GitHub interprets the URL as relative. This is a bug that should be fixed on the Atlantis side but that should fix it for you in the meantime.

[lkysow]

Closing unless I hear otherwise