Skip to content

Commit

Permalink
Add section for --var-file-allowlist in security doc (#2369)
Browse files Browse the repository at this point in the history
  • Loading branch information
lilincmu authored Jul 8, 2022
1 parent 6b0fe76 commit 4373b88
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions runatlantis.io/docs/security.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ To prevent this, you could:
use of disallowed providers or data sources or PRs from not allowed users. You could also add in extra validation at this point, e.g.
requiring a "thumbs-up" on the PR before allowing the `plan` to continue. Conftest could be of use here.
### `--var-file-allowlist`
The files on your Atlantis install may be accessible as [variable definition files](https://www.terraform.io/language/values/variables#variable-definitions-tfvars-files)
from pull requests by adding
`atlantis plan -- -var-file=/path/to/file` comments. To mitigate this security risk, Atlantis has limited such access
only to the files allowlisted by the `--var-file-allowlist` flag. If this argument is not provided, it defaults to
Atlantis' data directory.
### Webhook Secrets
Atlantis should be run with Webhook secrets set via the `$ATLANTIS_GH_WEBHOOK_SECRET`/`$ATLANTIS_GITLAB_WEBHOOK_SECRET` environment variables.
Even with the `--repo-allowlist` flag set, without a webhook secret, attackers could make requests to Atlantis posing as a repository that is allowlisted.
Expand Down

0 comments on commit 4373b88

Please sign in to comment.