Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New structured data extraction tutorial, cleanup and crosslinks #16979

Merged
merged 1 commit into from
Nov 15, 2024
Merged

New structured data extraction tutorial, cleanup and crosslinks #16979

merged 1 commit into from
Nov 15, 2024
+492 −66

Conversation

seldo
Copy link
Contributor

@seldo seldo commented Nov 15, 2024

No description provided.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 15, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

logan-markewich
logan-markewich approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@logan-markewich logan-markewich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read this a few times, so I don't have much to add -- looks great!

(it would be nice for newer sections if they were numbered in the file name, so that they sort start->end, but thats just me)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@seldo seldo merged commit 670459c into main Nov 15, 2024
11 checks passed
@seldo seldo deleted the ljv/structured-extraction branch November 15, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seldo @logan-markewich