Improvement/sambanova integration sambastudio #16930
Conversation
…hat, complete, stream chat, stream complete, async chat and async complete
…va_integration' into improvement/sambanova_integration
dosubot
bot
added
the
size:XXL
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
hey @nerdai, hope you're doing fine. Here's the SambaStudio integration that I talked to you about days before. Please take a look and let me know if you have any questions or observations where I can help. Thanks in advance! |
| @@ -9,10 +9,10 @@ skip = "*.csv,*.html,*.json,*.jsonl,*.pdf,*.txt,*.ipynb" | |||
|
|
|||
| [tool.llamahub] | |||
| contains_example = false | |||
| import_path = "llama_index.llms.sambanovacloud" | |||
| import_path = "llama_index.llms.sambanova" | |||
There was a problem hiding this comment.
any reason to rename all the imports and names?
There was a problem hiding this comment.
hey @logan-markewich I work for SambaNova and we noticed that the last author did an integration that wasn't working. We're very interested in this integration and would like to have the proper generic name so users can choose whether to use SambaNovaCloud or SambaStudio. Please let us know if there's a way to accomplish this.
There was a problem hiding this comment.
Unfortunately, someone published under the name llama-index-llms-sambanova already, so unless we found them and got them to transfer the name to our account (probably not easy), thats not an option
I would suggest either adding another llama-index-llms-sambanovastudio package. Or maybe there's some other alternative name that would work for both
There was a problem hiding this comment.
I see, that's unfortunate. No problem, we'll choose another name to have both classes in one single base file. Thanks for your suggestions.
| name = "llama-index-llms-sambanovacloud" | ||
| authors = ["Rodrigo Maldonado <[email protected]>"] | ||
| description = "llama-index llms sambanova cloud and sambastudio integration" | ||
| name = "llama-index-llms-sambanova" |
There was a problem hiding this comment.
We cannot publish under this name, as someone published something else under this name. This is why everything was renamed to samba nova cloud
There was a problem hiding this comment.
could coauthoring resolve the issue? I know the last author introduced SambaNova to LlamaIndex, but our endpoints changed and these are our current ones active and updated
There was a problem hiding this comment.
(see above comment)
There was a problem hiding this comment.
thanks, will undo changes in sambanova and change sambanovacloud to another more generic name
|
@rodrigo-92 not sure if you missed this, but this is already published and released? |
|
@logan-markewich awesome! although in this PR we're updating the notebook including SambaStudio. Is that ok? |
|
@rodrigo-92 thats fine -- but lets edit the PR to keep the same class names/folder names etc? Also, I noticed the notebook makes some mentions of the |
|
ok langchain mentions removed in notebook. What do you mean keeping the same class names/folder names? |
|
@rodrigo-92 I meant, you renamed all the folders to |
|
hey @logan-markewich please let me know if the changes work for you and if there's anything else. |
Description
Integration of SambaStudio to the sambanova LLM integration module in LlamaIndex.
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods