Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play Text Animations" settings option + russian translation updates #499

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

BlueGradientHorizon
Copy link
Contributor

Hello. I'm using system animation duration set to 0x (disabled), and that's how too wide ScrollableText elements were behaving for me:
Download_ezgif-7-e0dbeadf1d
Now, the animation won't be played if duration scale is quicker than 0.25x.

@rumboalla
Copy link
Owner

This is a bit hacky, an acceptable solution would be to add an option to disable animations in Settings.

@BlueGradientHorizon BlueGradientHorizon marked this pull request as draft January 20, 2024 19:25
@BlueGradientHorizon BlueGradientHorizon changed the title Play ScrollableText animations only if in android dev settings animation duration scale is set to 0.25x or slower "Play Text Animations" settings option + russian translation updates Jan 21, 2024
@BlueGradientHorizon BlueGradientHorizon marked this pull request as ready for review January 21, 2024 08:35
@BlueGradientHorizon
Copy link
Contributor Author

Added new option in settings to disable text animations if needed, ic_animation.xml svg icon for that option. Tiny change in ScrollableText and small russian translation updates.

@rumboalla rumboalla merged commit 70552cb into rumboalla:3.x Jan 22, 2024
1 check passed
@BlueGradientHorizon BlueGradientHorizon deleted the anim-fix branch January 22, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants