Added support for converting arbitrary fractions #96
Conversation
| "⅜": 3 / 8, | ||
| "⅝": 5 / 8, | ||
| "⅞": 7 / 8 | ||
| const afractions = Object.freeze({ |
There was a problem hiding this comment.
Hmm, now I don't quite get the different from afractions to fractions? Is it just to have an intermediate variable?
If so, I still don't like that naming by putting a "random" a in front… like maybe name it even fractionsTemp or even better put it out of scope completely, so no one can accidentally use the "intermediate/temp" variable.
Like maybe having a function getFractions or so that defines this inline?
IMHO that would be good.
There was a problem hiding this comment.
Both fractions variables are used. In order to support the new arbitrary fraction replacements, we need the separate numerator and denominator values for these hardcoded Unicode fraction characters, so I had to add an additional variable.
| * @returns {string} | ||
| */ | ||
| function sentenceCase(text) { | ||
| return Array.from(segmenter2.segment(text), ({ segment: [h, ...t] }) => h.toLocaleUpperCase() + t.join("")).join(""); |
There was a problem hiding this comment.
h and t … can we find a long name for that?
There was a problem hiding this comment.
h = head and t = tail.
| const result = Object.entries(afractions).find(([, [anumerator, adenominator]]) => anumerator === numerator && adenominator === denominator); | ||
| let label; | ||
| if (result) { | ||
| [label] = result; |
There was a problem hiding this comment.
Uhm this syntax looks wild to me… just curious what is that? 😲
Puts it into an array?
There was a problem hiding this comment.
This is just using the destructuring assignment syntax. I find it cleaner than writing the equivalent:
label = result[0];
Intl.Segmenter.RegExp.escapeif available.