Added option for a nested context menu #84
Conversation
tdulcet
commented
Nov 12, 2023
tdulcet
commented
- Added option for a nested context menu and enabled it by default. Fixes Option for nested context menu #44
- Enabled the Subscript Unicode font added in Disable autocorrect feature by default #72.
- Enabled the existing readable text and live preview options by default.
|
We should probably give some thought to this from #44 (comment):
|
|
Yeah, but IMHO your screenshot looks nice. And thanks, this looks good! |
| title: menuText, | ||
| contexts: ["editable"] | ||
| }); | ||
| for (const atransformationId of amenuItems) { |
There was a problem hiding this comment.
I am still not convinced by this a prefixing again. And here it looks absurd as it is grammatically wrong in English, I mean what is "a menu items"? Plural/singular what?
| for (const atransformationId of amenuItems) { | |
| for (const currentTransformationId of currentMenuItems) { |
There was a problem hiding this comment.
Also I ponder whether this could be written/refactored with less indentation in a recursive way or so, just unsure. So e.g. check if the item is a list and then call the function itself to add it to a new list in a sub-item.
This could drastically reduce the code and complexity and make the code more understandable.
As an addition you can then easily build more sub-entries recursively.
There was a problem hiding this comment.
OK, I will remove the a prefixes.
Regarding refactoring, I am open to suggestions. I doubt there would ever be multiple levels of nesting, as it would then make it too difficult for users to use.
There was a problem hiding this comment.
Well yeah, recursive is likely more readable anyway, but it's okish… (It's just quote hard to understand currently, so…)
Co-authored-by: rugk <[email protected]>
