ESLint and TSC fixes #142
Merged
ESLint and TSC fixes #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rugk
previously approved these changes
Aug 2, 2023
rugk
reviewed
Aug 2, 2023
rugk
approved these changes
Aug 7, 2023
|
WebExt Linting fails, but I'll ignore that given it is clöearly a different issue, reported as https://github.com/mozilla/web-ext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as: rugk/unicodify#79
Note that I did not make all the needed fixes, just some of the low hanging fruit so to speak. Some of the JSDoc comments in your various libraries would also need to be fixed for the TypeScript compiler to work better.