Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating PSR-0 in favor of PSR-4 #714

Merged
merged 1 commit into from
Oct 31, 2014
Merged

Deprecating PSR-0 in favor of PSR-4 #714

merged 1 commit into from
Oct 31, 2014

Conversation

skymeyer
Copy link
Contributor

As of 2014-10-21 PSR-0 has been marked as deprecated. PSR-4 is now recommended as an alternative (http://www.php-fig.org/psr/psr-0)

@skymeyer
Copy link
Contributor Author

Not getting a lot of love from one of the stacks ... OutOfMemoryError

@fprochazka
Copy link
Contributor

Sorry, but there is no added value in this pull. The PSR-4 is meant to simplify directory structure. And you haven't simplified the directory structure.

@skymeyer
Copy link
Contributor Author

There is no requirement to change the directory structure for moving to PSR-4, that's totally optional. The code tree isn't that complex worth the effort. PSR-0 is now officially deprecated and all major projects are shifting away from it so I do not see for which reason Elastica shouldn't jump on the band wagon as there is no harm.

There might be no direct added value for the library itself (apart from moving the test folder up a bit) - we should encourage adopting the PSR-4 standard unless there is a legit reason not to. Also take a look at this topic composer/composer#1884 (comment) regarding priority in Composer's autoloading (although it doesn't apply when using full classmap).

@ruflin
Copy link
Owner

ruflin commented Oct 31, 2014

@skymeyer I'm happy to have PSR-4 as a first step in place. As I'm not too familar with PSR-4 yet: Could there be any issues with projects that are still using PSR-0?

@fprochazka
Copy link
Contributor

@skymeyer I know it's optional, but the whole point of PSR-4 is to have simpler directory structure. This is just PSR-0 masked as PSR-4 => no added value.

Please note, that I'm not saying this pull is bad, I support the adoption of PSR-4, but let's call things with their real names. I'm just saying, that this is not enough and should go further => simplified directory structure.

@ruflin not if they're using composer.

ruflin added a commit that referenced this pull request Oct 31, 2014
Deprecating PSR-0 in favor of PSR-4
@ruflin ruflin merged commit fc5eb62 into ruflin:master Oct 31, 2014
@ruflin
Copy link
Owner

ruflin commented Oct 31, 2014

I merged the pull request and opened an issue here for further migration to PSR-4: #715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants