Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerPHP AllowSymfonyFlexPlugin on phpuser for phpunit #2194

Conversation

daminuxfork
Copy link
Contributor

@daminuxfork daminuxfork commented Feb 29, 2024

Allow (to false) SymfonyFlex plugin for phpuser on make docker-run-phpunit

Love tests on docker ;)

@daminuxfork daminuxfork marked this pull request as ready for review February 29, 2024 18:34
@ruflin
Copy link
Owner

ruflin commented Mar 4, 2024

Can you share a bit more background (link or comment) on what this exactly does / allows?

@daminuxfork
Copy link
Contributor Author

daminuxfork commented Mar 5, 2024

Can you share a bit more background (link or comment) on what this exactly does / allows?

As noted, I really like the idea of docker fulfilling its role of abstracting the host's technical stack.

After recovering the projects to work on the unit testing part, I executed make docker-start, then make docker-run-phpunit and I encountered this error, for which I propose this fix (see screenshot below).

image

@ruflin
Copy link
Owner

ruflin commented Mar 6, 2024

My initial reaction was, it seems like this is the wrong place but I just found out, 4 years ago we added this dependency to the project :-)

composer global require --no-progress --no-scripts --no-plugins symfony/flex

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Can you add a quick note to the changelog?

@daminuxfork
Copy link
Contributor Author

daminuxfork commented Mar 6, 2024

Done !
sorry mistake bad group of changes

@daminuxfork
Copy link
Contributor Author

move type of changes ok.

@ruflin ruflin merged commit fd6f286 into ruflin:8.x Mar 7, 2024
19 checks passed
@ruflin
Copy link
Owner

ruflin commented Mar 7, 2024

@daminuxfork Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants