Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations passing $options as int #2148

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

franmomu
Copy link
Contributor

The deprecation was only in Search::setOptionsAndQuery() method, but it affected the other ones.

@franmomu franmomu force-pushed the remove-deprecation-options-search branch from 4b34649 to c8d5419 Compare February 26, 2023 11:49
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the changes I wonder how big the impact will be. I like the change but I wonder if we should still allow null to be passed in:

$index->search('hans', null, Request::GET);

I expect that is something quite a few will use instead of

$index->search('hans', [], Request::GET);

Our code gets cleaner by removing it but search is likely one of the most used functions in the library. So changing it can have a big impact. Thoughts?

@franmomu franmomu force-pushed the remove-deprecation-options-search branch 2 times, most recently from 14d00b2 to 70593bd Compare February 27, 2023 07:45
@franmomu
Copy link
Contributor Author

franmomu commented Feb 27, 2023

thanks for the review! In this case the only deprecation was to pass an int, so I think it makes sense to allow null. I guess I removed it because I did this one after #2147

@franmomu franmomu force-pushed the remove-deprecation-options-search branch from 70593bd to 72dbb34 Compare March 3, 2023 22:20
@franmomu franmomu changed the title Remove deprecations passing $options as int or null Remove deprecations passing $options as int Mar 3, 2023
@ruflin ruflin merged commit c2331b9 into ruflin:8.x Mar 7, 2023
@franmomu franmomu deleted the remove-deprecation-options-search branch March 7, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants