New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some types #2144

Merged

ruflin merged 1 commit into ruflin:8.x from franmomu:fix_types

Jan 16, 2023

Contributor

franmomu commented Jan 16, 2023

I was trying to use strict types and some issues appeared:

active_shards_percent_as_number returns a float according to https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-health.html#cluster-health-api-response-body
Elastica\Multi\Search:: addSearch() $key parameter could be an int if no key is specified when calling addSearches or setSearches.


          fix types

25c120f

ruflin approved these changes

View reviewed changes

ruflin merged commit cec3102 into ruflin:8.x

franmomu deleted the fix_types branch

January 16, 2023 08:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet