Bump PHPStan to level 5

[franmomu]

Most of the ignored errors are expected because they are testing exceptions using wrong types and PHPStan complains about that. Like:

Elastica/tests/Aggregation/GeohashGridTest.php

Lines 51 to 57 in 8fe6176

	public function testGeohashGridAggregationWithNotAllowedPrecision(): void
	{
	$this->expectException(\TypeError::class);
	$agg = new GeohashGrid('hash', 'location');
	$agg->setPrecision(1.5);
	}

 ------ ---------------------------------------------------------------------------------------------------------------------
  Line   tests/Aggregation/GeohashGridTest.php
 ------ ---------------------------------------------------------------------------------------------------------------------
  56     Parameter #1 $precision of method Elastica\Aggregation\GeohashGrid::setPrecision() expects int|string, float given.
 ------ ---------------------------------------------------------------------------------------------------------------------

The different ones are:

• The ones in tests/Query/FunctionScoreTest.php, which I think it's fine to add TODO just in case someone has overridden FunctionScore::addDecayFunction() method, if this is fine we can close Allow int and float for FunctionScore::addDecayFunction() origin and scale #2089
• In ClientFunctionTest, there is a call to Document::setIndex() passing null which is not allowed, that is done to make sure that the index is properly set when deleting the documents. Instead of that a new document can be passed as we do lines above to update them:
  

  Elastica/tests/ClientFunctionalTest.php

  Lines 161 to 182 in 8fe6176

  	$anonCoin = new Document('1', ['name' => 'anoncoin']);
  	$ixCoin = new Document('2', ['name' => 'ixcoin']);
  	$index->addDocuments([$anonCoin, $ixCoin]);
  	$this->assertEquals('anoncoin', $index->getDocument(1)->get('name'));
  	$this->assertEquals('ixcoin', $index->getDocument(2)->get('name'));
  	$index->updateDocuments([
  	new Document('1', ['name' => 'AnonCoin']),
  	new Document('2', ['name' => 'iXcoin']),
  	]);
  	$this->assertEquals('AnonCoin', $index->getDocument(1)->get('name'));
  	$this->assertEquals('iXcoin', $index->getDocument(2)->get('name'));
  	$ixCoin->setIndex(null); // Make sure the index gets set properly if missing
  	$index->deleteDocuments([$anonCoin, $ixCoin]);
  	$this->expectException(NotFoundException::class);
  	$index->getDocument(1);
  	$index->getDocument(2);

[ruflin]

Why do you need to recreate the doc here for this change? I also wander why we do it onl line 170/171?

[franmomu]

I've updated the test to reuse the documents and added a couple of tests to check that the index is set if missing (to remove the $ixCoin->setIndex(null); part)

[ruflin]

Trying to get my head around why we don't fix these in the test files directly? Related to breaking changes?

[franmomu]

This is what it was explained in the PR description #2108 (comment), a test like this:

Elastica/tests/Aggregation/GeohashGridTest.php

Lines 51 to 57 in 8fe6176

	public function testGeohashGridAggregationWithNotAllowedPrecision(): void
	{
	$this->expectException(\TypeError::class);
	$agg = new GeohashGrid('hash', 'location');
	$agg->setPrecision(1.5);
	}

makes PHPStan fails because setPrecision only accepts int|string:

Elastica/src/Aggregation/GeohashGrid.php

Lines 42 to 50 in 6d51cdb

	* @param int|string $precision an integer between 1 and 12, inclusive. Defaults to 5 or distance like 1km, 10m
	*
	* @return $this
	*/
	public function setPrecision($precision): self
	{
	if (!\is_int($precision) && !\is_string($precision)) {
	throw new \TypeError(\sprintf('Argument 1 passed to "%s()" must be of type int|string, %s given.', __METHOD__, \is_object($precision) ? \get_class($precision) : \gettype($precision)));
	}

We can get rid of these ignored errors and checks in the next major if we add type parameter declarations.

[ruflin]

@franmomu Thanks for getting us to phpstan level 5