Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPStorm findings #2087

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Fix PHPStorm findings #2087

merged 3 commits into from
Jun 24, 2022

Conversation

franmomu
Copy link
Contributor

This doesn't fix any PHPStan issue, but some PHPStorm findings.

The PHPDoc code that has been removed is because it didn't match the method signature and once that has been fixed, php-cs-fixer removes it.

I'll add some a couple of comments in the code about the PHPDoc changes.

@@ -34,7 +34,7 @@ class Action
protected $_metadata = [];

/**
* @var array
* @var array|string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on

/**
* @param array|string $source
*
* @return $this
*/
public function setSource($source): self
{
$this->_source = $source;
return $this;
}
/**
* @return array|string
*/
public function getSource()
{
return $this->_source;
}

@deguif deguif merged commit a0a2dc2 into ruflin:master Jun 24, 2022
@franmomu franmomu deleted the phpstorm_findings branch June 24, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants