Add 'ignore_failure' option to ingest processors #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
force-pushed
the
ingest-processor-ignore-failure
branch
3 times, most recently
from
55790cc
to
80c19dd
Compare
ruflin
reviewed
Oct 25, 2021
| $processor = new SplitProcessor('joined_array_field', '-'); | ||
| $processor->setIgnoreMissing(true); | ||
| $processor = (new SplitProcessor('joined_array_field', '-')) | ||
| ->setIgnoreFailure(true) |
There was a problem hiding this comment.
Assuming this test was not updated, I assume it would just have worked as before as the default did not change?
There was a problem hiding this comment.
testSplitWithNonDefaultOptions I interpreted this test as testing options that are not put by default, so I added the new option here to test it was rightly set.
deguif
force-pushed
the
ingest-processor-ignore-failure
branch
from
80c19dd
to
31474ec
Compare
ruflin
approved these changes
Oct 25, 2021
| $processor = new SplitProcessor('joined_array_field', '-'); | ||
| $processor->setIgnoreMissing(true); | ||
| $processor = (new SplitProcessor('joined_array_field', '-')) | ||
| ->setIgnoreFailure(true) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.