Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.0] Use AWS SDK package version compatible #1798

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Sep 25, 2020

No description provided.

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a changelog entry for awareness?

@deguif
Copy link
Collaborator Author

deguif commented Sep 28, 2020

That's a dev dependency, so is a changelog required ?

@ruflin ruflin merged commit 39ecb49 into ruflin:master Sep 28, 2020
@ruflin
Copy link
Owner

ruflin commented Sep 28, 2020

@deguif Good point. Probably not so I merged.

@deguif deguif deleted the php-8-aws-sdk branch September 28, 2020 08:56
@deguif deguif mentioned this pull request Oct 19, 2020
8 tasks
ruflin pushed a commit that referenced this pull request Oct 20, 2020
#### Done in this PR:

- [x] Update composer constraint to allow PHP 8.0.
- [x] Update travis configuration in order to run tests on PHP 8.0 (nightly).
- [x] Update changelog

#### Done in previous PRs:
- [x] Deprecate `Elastica\Query\Match` class and add a new `Elastica\Query\MatchQuery` class as match is now a reserved keyword. [#1799]
- [x] Update phpunit version in order to be compatible with PHP 8.0. [#1811]
- [x] Bump `aws/aws-sdk-php` package version to fix a bug with PHP 8.0. [#1798]

#### Done in external PRs:
- [x] Wait for `aws/aws-sdk-php` to be compatible with PHP 8. [aws/aws-sdk-php#2079]
- [ ] Wait for `elasticsearch/elasticsearch` to be compatible with PHP 8.0 and remove `--ignore-platform-reqs` composer option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants