Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ES 7.3 #1650

Merged
merged 1 commit into from
Aug 15, 2019
Merged

update to ES 7.3 #1650

merged 1 commit into from
Aug 15, 2019

Conversation

p365labs
Copy link
Collaborator

update Elasticsearch version to ES 7.3

@ruflin ruflin merged commit 5f71248 into ruflin:master Aug 15, 2019
@ruflin
Copy link
Owner

ruflin commented Aug 15, 2019

Thanks. Now that I'm back we should really get Elastica 7.0 out ;-)

@p365labs p365labs deleted the update_ES7_3 branch August 15, 2019 22:56
@p365labs
Copy link
Collaborator Author

@ruflin yes I think we need to release a 7.x version

@ruflin
Copy link
Owner

ruflin commented Aug 19, 2019

@p365labs What is your view on where we are stading to ship a 7.x (or a beta first?)

@p365labs
Copy link
Collaborator Author

p365labs commented Aug 19, 2019

@ruflin I think we can release the new version skipping the beta version:
people who need/wanted to work on 7.x branch used dev-master since June 2019.
Bugs or problems should have been already notified by our user base.

The only doubts I have is that, maybe, we don't have implemented all the features of 7.x
I will do a review to all the BC changes/new features in the Elastic documentation and I will come back to you tomorrow. After that we can have a clear view of what we have on master :)

how does it sounds?

@ruflin
Copy link
Owner

ruflin commented Aug 27, 2019

SGTM :-) I think it's ok if we don't have all the features of 7.x in Elastica, we can always add them if needed and there is also the underlying official php client which can be used for non existing features.

The part I'm more worried about: Are we done with the breaking change? This will be our last chance for quite a few months :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants