Add request method parameter for search and count

[alamirault]

This PR allow to change request method for search and count as discussed in #1441.

BC BREAK

I also moved default request method from GET to POST as suggested by @ruflin in his comment.

[ruflin]

@alamirault Thanks for taking this on and sorry for the late reply, was on paternity leave ;-) I restarted CI to see if it was just a temporary failure or not. I assume your commit it based on current master?

[alamirault]

Congratulation ! I was based on master, il will rebase on current.
Some tests failed because POST is set by default and they check dynamic changes. Should I delete them?

[ruflin]

Thanks :-) Should the tests be deleted or just adapted? Can you share a link to the culprits?

[alamirault]

Elastica/test/Elastica/Transport/GuzzleTest.php

Line 46 in bbe10bc

public function testDynamicHttpMethodBasedOnConfigParameter(array $config, $httpMethod)

I think this test must be deleted. Or I should rework my PR in order to keep GET by default, change to POST only if search have data. And the $method arg (nullable by default) allow to override this behavior. I think is less predictive.

[ruflin]

If POST is the expected default, I think we should fully switch to POST and not have as you said, a less predictive behaviour. So far I can't see any downsides?

+1 on deleting the test.

[alamirault]

Code is rebased and I deleted the test.

[ruflin]

LGTM. Thanks for all the additional tests.