Add processor target_field trait (#2026)

* Add processor target_field trait * Add changelog
ruflin · Nov 24, 2021 · cb28c9d · cb28c9d
1 parent 6b92d87
commit cb28c9d
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 70 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Updated `php-cs-fixer` to `3.3.2` [#2022](https://github.com/ruflin/Elastica/pull/2022)
 * Updated `composer-normalize` to `2.15.0` [#2021](https://github.com/ruflin/Elastica/pull/2021)
 * Extracted setting gap policy to `\Elastica\Aggregation\Traits\GapPolicyTrait` and introduced `\Elastica\Aggregation\GapPolicyInterface` with constants for options [#2023](https://github.com/ruflin/Elastica/pull/2023)
+* Extracted setting `target_field` to `Elastica\Processor\Traits\TargetFieldTrait` [#2026](https://github.com/ruflin/Elastica/pull/2026)
 ### Deprecated
 * Deprecated `Elastica\Query\Common` class, use `Elastica\Query\MatchQuery` instead [#2013](https://github.com/ruflin/Elastica/pull/2013)
 * Deprecated `Elastica\QueryBuilder\DSL\Query::common_terms()`, use `match()` instead [#2013](https://github.com/ruflin/Elastica/pull/2013)

diff --git a/src/Processor/AttachmentProcessor.php b/src/Processor/AttachmentProcessor.php
@@ -12,6 +12,7 @@
 class AttachmentProcessor extends AbstractProcessor
 {
     use Traits\IgnoreMissingTrait;
+    use Traits\TargetFieldTrait;
 
     public const DEFAULT_TARGET_FIELD_VALUE = 'attachment';
     public const DEFAULT_INDEXED_CHARS_VALUE = 100000;
@@ -32,16 +33,6 @@ public function setField(string $field): self
         return $this->setParam('field', $field);
     }
 
-    /**
-     * Set target_field. Default attachment.
-     *
-     * @return $this
-     */
-    public function setTargetField(string $targetField): self
-    {
-        return $this->setParam('target_field', $targetField);
-    }
-
     /**
      * Set indexed_chars. Default 100000.
      *

diff --git a/src/Processor/BytesProcessor.php b/src/Processor/BytesProcessor.php
@@ -9,6 +9,7 @@ class BytesProcessor extends AbstractProcessor
 {
     use Traits\IgnoreFailureTrait;
     use Traits\IgnoreMissingTrait;
+    use Traits\TargetFieldTrait;
 
     public function __construct(string $field)
     {
@@ -24,14 +25,4 @@ public function setField(string $field): self
     {
         return $this->setParam('field', $field);
     }
-
-    /**
-     * Set target_field.
-     *
-     * @return $this
-     */
-    public function setTargetField(string $targetField): self
-    {
-        return $this->setParam('target_field', $targetField);
-    }
 }
diff --git a/src/Processor/ConvertProcessor.php b/src/Processor/ConvertProcessor.php
@@ -13,6 +13,7 @@ class ConvertProcessor extends AbstractProcessor
 {
     use Traits\IgnoreFailureTrait;
     use Traits\IgnoreMissingTrait;
+    use Traits\TargetFieldTrait;
 
     public const DEFAULT_TARGET_FIELD_VALUE = 'field';
     public const DEFAULT_IGNORE_MISSING_VALUE = false;
@@ -42,14 +43,4 @@ public function setType(string $type): self
     {
         return $this->setParam('type', $type);
     }
-
-    /**
-     * Set target_field. Default value field.
-     *
-     * @return $this
-     */
-    public function setTargetField(string $targetField): self
-    {
-        return $this->setParam('target_field', $targetField);
-    }
 }
diff --git a/src/Processor/DateProcessor.php b/src/Processor/DateProcessor.php
@@ -12,6 +12,7 @@
 class DateProcessor extends AbstractProcessor
 {
     use Traits\IgnoreFailureTrait;
+    use Traits\TargetFieldTrait;
 
     public const DEFAULT_TARGET_FIELD_VALUE = '@timestamp';
     public const DEFAULT_TIMEZONE_VALUE = 'UTC';
@@ -43,16 +44,6 @@ public function setFormats(array $formats): self
         return $this->setParam('formats', $formats);
     }
 
-    /**
-     * Set target_field. Default value @timestamp.
-     *
-     * @return $this
-     */
-    public function setTargetField(string $targetField): self
-    {
-        return $this->setParam('target_field', $targetField);
-    }
-
     /**
      * Set the timezone use when parsing the date. Default UTC.
      *

diff --git a/src/Processor/JsonProcessor.php b/src/Processor/JsonProcessor.php
@@ -12,6 +12,7 @@
 class JsonProcessor extends AbstractProcessor
 {
     use Traits\IgnoreFailureTrait;
+    use Traits\TargetFieldTrait;
 
     public const DEFAULT_TARGET_FIELD_VALUE = 'field';
     public const DEFAULT_ADD_TO_ROOT_VALUE = false;
@@ -31,16 +32,6 @@ public function setField(string $field): self
         return $this->setParam('field', $field);
     }
 
-    /**
-     * Set target_field. Default field.
-     *
-     * @return $this
-     */
-    public function setTargetField(string $targetField): self
-    {
-        return $this->setParam('target_field', $targetField);
-    }
-
     /**
      * Set add_to_root. Default value false.
      *

diff --git a/src/Processor/KvProcessor.php b/src/Processor/KvProcessor.php
@@ -13,6 +13,7 @@ class KvProcessor extends AbstractProcessor
 {
     use Traits\IgnoreFailureTrait;
     use Traits\IgnoreMissingTrait;
+    use Traits\TargetFieldTrait;
 
     public const DEFAULT_TARGET_FIELD_VALUE = null;
     public const DEFAULT_IGNORE_MISSING_VALUE = false;
@@ -54,16 +55,6 @@ public function setValueSplit(string $valueSplit): self
         return $this->setParam('value_split', $valueSplit);
     }
 
-    /**
-     * Set target_field. Default value null.
-     *
-     * @return $this
-     */
-    public function setTargetField(string $targetField): self
-    {
-        return $this->setParam('target_field', $targetField);
-    }
-
     /**
      * Set include_keys.
      *

diff --git a/src/Processor/RenameProcessor.php b/src/Processor/RenameProcessor.php
@@ -13,6 +13,7 @@ class RenameProcessor extends AbstractProcessor
 {
     use Traits\IgnoreFailureTrait;
     use Traits\IgnoreMissingTrait;
+    use Traits\TargetFieldTrait;
 
     public const DEFAULT_IGNORE_MISSING_VALUE = false;
 
@@ -31,14 +32,4 @@ public function setField(string $field): self
     {
         return $this->setParam('field', $field);
     }
-
-    /**
-     * Set target_field.
-     *
-     * @return $this
-     */
-    public function setTargetField(string $targetField): self
-    {
-        return $this->setParam('target_field', $targetField);
-    }
 }
diff --git a/src/Processor/Traits/TargetFieldTrait.php b/src/Processor/Traits/TargetFieldTrait.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace Elastica\Processor\Traits;
+
+trait TargetFieldTrait
+{
+    /**
+     * @return $this
+     */
+    public function setTargetField(string $targetField): self
+    {
+        return $this->setParam('target_field', $targetField);
+    }
+}