-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binary diff #26
Fix binary diff #26
Conversation
as diff could be from binary file
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 97.18% 97.20% +0.01%
==========================================
Files 19 19
Lines 569 572 +3
Branches 79 82 +3
==========================================
+ Hits 553 556 +3
Misses 9 9
Partials 7 7
Continue to review full report at Codecov.
|
instead of hashing diff output to avoid issues with diffing binary files https://git-scm.com/docs/git-hash-object
e3ca95a
to
02a9231
Compare
02a9231
to
1f7cca2
Compare
CC @SteveMacenski , This should fix the CI issue with changed binary files in git repos:
|
Don't try to encode diff using utf-8 as diff could be from binary file