avm1, avm2: Correct TextFormat properties coercion
#5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
reviewed
Nov 15, 2021
Put a single implementation in `ecma_conversions.rs`. Need to consider what to do with the similar implementation in `matrix.rs`.
adrian17
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many properties are coerced using the IEEE-754 "Round to nearest, ties to even" rounding rule (e.g., both 1.5 and 2.5 will round to 2).
Although this is easy to do on most architectures, Rust provides no standard way to round in this manner (
f64::roundalways rounds away from zero). For more info see: rust-lang/rust#55107Add tests that also cover #5569 and #5610.