-
-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop: Move open URLs mode from launch options to preferences #18233
Open
kjarosh
wants to merge
9
commits into
ruffle-rs:master
Choose a base branch
from
kjarosh:open-links-preference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+247
−95
Commits on Oct 10, 2024
-
desktop: Move open_url_mode check to the DesktopNavigatorInterface
This allows for greater control over opening URLs on desktop, e.g. makes it possible to change the mode in runtime without reinstantiating everything.
Configuration menu - View commit details
-
Copy full SHA for 3711f03 - Browse repository at this point
Copy the full SHA 3711f03View commit details -
desktop: Add OpenUrlMode to cli & make Confirm the default
OpenUrlModePreference is strictly related to the desktop, which decouples it from the core in this regard. Additionally this patch makes Confirm the default, as it prepares it to be added to Ruffle preferences.
Configuration menu - View commit details
-
Copy full SHA for e6f2984 - Browse repository at this point
Copy the full SHA e6f2984View commit details -
desktop: Add open_url_mode config value to preferences
This value controls how links are opened.
Configuration menu - View commit details
-
Copy full SHA for a8f1bf0 - Browse repository at this point
Copy the full SHA a8f1bf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f52676 - Browse repository at this point
Copy the full SHA 9f52676View commit details -
Configuration menu - View commit details
-
Copy full SHA for b30183d - Browse repository at this point
Copy the full SHA b30183dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd3fc99 - Browse repository at this point
Copy the full SHA bd3fc99View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbc4aab - Browse repository at this point
Copy the full SHA cbc4aabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 308c91c - Browse repository at this point
Copy the full SHA 308c91cView commit details -
core: Move OpenURLMode from core to web
After changes in desktop, this is the only place where it is used. This additionally renames it to OpenUrlMode.
Configuration menu - View commit details
-
Copy full SHA for 7a60229 - Browse repository at this point
Copy the full SHA 7a60229View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.