Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix compilation warnings on non-Linux #17971

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Sep 18, 2024

This fixes the following warning on macOS & Windows (and probably others that we do not build for here).

warning: unused import: `futures::StreamExt`
 --> desktop/src/gui/theme.rs:5:5
  |
5 | use futures::StreamExt;
  |     ^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: `ruffle_desktop` (bin "ruffle_desktop" test) generated 1 warning (run `cargo fix --bin "ruffle_desktop" --tests` to apply 1 suggestion)

@kjarosh kjarosh added A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Sep 18, 2024
@Dinnerbone
Copy link
Contributor

Thank you, this has been bugging me but I keep forgetting to do anything about it :D

@torokati44
Copy link
Member

Same! 😄💯

@Dinnerbone
Copy link
Contributor

(should we do optional clippy runs on mac/windows, rust-stable?)

@torokati44 torokati44 merged commit bade6dd into ruffle-rs:master Sep 18, 2024
17 checks passed
@torokati44
Copy link
Member

should we do optional clippy runs on mac/windows, rust-stable?

Or at least pipe out the warnings/notes as "annotations" to the workflow runs/jobs somehow...?

@kjarosh kjarosh deleted the warnings branch September 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants