chore: Improve iOS support #17950
Merged
chore: Improve iOS support #17950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
reviewed
Sep 16, 2024
danielhjacobs
added
A-desktop
|
I think these changes look fine, and will likely end up being accepted; but it looks like they can be split into two main parts - even though they are serving the same goal. Would you mind splitting out the audio backend refactor into its own PR please, just for easier review discussion? |
adrian17
approved these changes
Sep 16, 2024
|
Yeah, that was lazy of me, sorry, I've made #17951 for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few instances of
target_os = "macos". Required for https://github.com/madsmtm/ruffle-ios.